fix unit tests by restoring .fits files and using MODEL_IMAGe#1129
Merged
fix unit tests by restoring .fits files and using MODEL_IMAGe#1129
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1129 +/- ##
==========================================
- Coverage 81.48% 81.40% -0.08%
==========================================
Files 207 207
Lines 15893 15933 +40
==========================================
+ Hits 12951 12971 +20
- Misses 2942 2962 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rhayes777
approved these changes
Apr 25, 2025
Comment on lines
-30
to
+31
| ModelImage = "MODEL_IMAGE" | ||
| ModelData = "MODEL_IMAGE" |
Collaborator
There was a problem hiding this comment.
It's less confusing if name and value contain the same words but not absolutely necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following PR add a .csv visualization file for irregular source reconstructions:
https://github.com/Jammy2211/PyAutoLens/compare/feature/fits_reconstruction?expand=1
This PR adds a method to
AggregateFITSwhich loads these .csv files as lists of dictionaries.Its a bit odd it being in
AggregateFITS, but doesn't fit with the usage of otherAggregateobjects and I dont want to make a new one. There will be more .csv visuals in the future so I woill think about how to approach this going forward.