Skip to content

remove CombinedAnalysis summing API #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jammy2211 merged 1 commit into from
May 16, 2025
Merged

remove CombinedAnalysis summing API #1135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions autofit/non_linear/analysis/analysis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,32 +237,3 @@ def profile_log_likelihood_function(self, paths: AbstractPaths, instance):
The maximum likliehood instance of the model so far in the non-linear search.
"""
pass

def __add__(self, other: "Analysis"):
"""
Analyses can be added together. The resultant
log likelihood function returns the sum of the
underlying log likelihood functions.

Parameters
----------
other
Another analysis class

Returns
-------
A class that computes log likelihood based on both analyses
"""
from .combined import CombinedAnalysis

if isinstance(other, CombinedAnalysis):
return other + self
return CombinedAnalysis(self, other)

def __radd__(self, other):
"""
Allows analysis to be used in sum
"""
if other == 0:
return self
return self + other
Loading