Feature/jax production#1149
Merged
Jammy2211 merged 8 commits intofeature/jax_wrapperfrom Jun 24, 2025
Merged
Conversation
added 8 commits
June 19, 2025 21:13
rhayes777
approved these changes
Jun 20, 2025
Collaborator
rhayes777
left a comment
rhayes777
left a comment
There was a problem hiding this comment.
Looks like all the failures are coming from core mp functionality
| assert grad[a] == pytest.approx(6) | ||
| assert grad[b] == pytest.approx(2) | ||
| assert grad[c] == pytest.approx(3) | ||
| # def test_nested_factor_jax(): |
Collaborator
Author
There was a problem hiding this comment.
Not sure, I am working my way through the graphical module indepedently so figure I'll come back to this down the line.
The failure message relates to a jax factor so it'll be due to me messing around with the JAX imports, maybe that I disabled JAX in the config for unit tests but this test is still trying to use it. PRobably that, tbh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes JAX a requirement and adapts and simplifies source code using this.
However, JAX can still be disabled using the
use_jaxinput ofgeneral.yaml, and most unit tests assume this to be the case.More simplifications and refactors will be necessary, but for now all unit tests and I can proceed testing things with autolens.