Merged
Conversation
…ore count When JAX is active, the "Starting non-linear search with 1 cores" message was inaccurate (JAX handles its own parallelization). Now logs the JAX backend and device instead. Similarly, Nautilus's "parallelization is disabled" message is replaced with a JAX-specific message when appropriate. Closes #1175 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When JAX is active, the non-linear search logging displayed misleading messages: "Starting non-linear search with 1 cores" (JAX manages its own cores/GPU) and "Running search where parallelization is disabled" (inaccurate for JAX). This PR makes both messages JAX-aware — reporting the JAX backend (CPU/GPU) and device, and replacing the parallelization message with an accurate JAX vectorization message.
API Changes
None — internal logging changes only.
Test Plan
pytest test_autofit/non_linear -x— all 222 tests pass unchangedStarting non-linear search with JAX (GPU: ...)or(CPU: ...)Starting non-linear search with N cores.message is unchangedRunning search with JAX vectorization (parallelization handled by JAX).appears instead of the old message📋 Full API Changes (for automation & release notes)
No public API changes. Internal logging only.
Changed Behaviour
NonLinearSearch.fit()log message now saysStarting non-linear search with JAX (<backend>: <device>).whenanalysis._use_jaxis True, instead ofStarting non-linear search with N cores.Nautilus.fit_x1_cpu()log message now saysRunning search with JAX vectorization (parallelization handled by JAX).whenanalysis._use_jaxis True, instead ofRunning search where parallelization is disabled.🤖 Generated with Claude Code