Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds elliptical cored-NFW (cNFW) support using MGE-based deflections and introduces corresponding MCR (Ludlow + scatter) variants, wiring them into public exports, configs, and tests.
Changes:
- Introduce
cNFW(elliptical) with deflections computed viaMGEDecomposer, and refactorcNFWSphto subclass it. - Add elliptical
cNFWMCRLudlow/cNFWMCRScatterLudlowimplementations and export them through package__init__modules. - Add/extend tests and prior configuration YAMLs for
cNFWand the new MCR variants.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test_autogalaxy/profiles/mass/dark/test_nfw_scatter.py | Extends scatter tests to cover elliptical cored-NFW MCR scatter behavior. |
| test_autogalaxy/profiles/mass/dark/test_nfw_mcr.py | Adds assertions comparing cNFW MCR Ludlow results to equivalent cNFW constructed from (kappa_s, scale_radius, core_radius). |
| autogalaxy/profiles/mass/dark/cnfw_mcr_scatter.py | Adds elliptical cNFWMCRScatterLudlow (inherits cNFW) alongside spherical variant. |
| autogalaxy/profiles/mass/dark/cnfw_mcr.py | Refactors Ludlow classes to inherit from scatter implementations with scatter_sigma=0.0. |
| autogalaxy/profiles/mass/dark/cnfw.py | Introduces cNFW with MGE-based deflections; makes cNFWSph a subclass. |
| autogalaxy/profiles/mass/dark/init.py | Exposes new cNFW + MCR classes from the dark-mass namespace. |
| autogalaxy/profiles/mass/init.py | Re-exports new dark-mass profile classes at the mass-profile namespace level. |
| autogalaxy/config/priors/mass/dark/cnfw_mcr_scatter.yaml | Adds priors for cNFWMCRScatterLudlow (elliptical) alongside existing spherical priors. |
| autogalaxy/config/priors/mass/dark/cnfw_mcr.yaml | Adds priors for cNFWMCRLudlow (elliptical) alongside existing spherical priors. |
| autogalaxy/config/priors/mass/dark/cnfw.yaml | Adds priors for cNFW (elliptical) alongside existing cNFWSph priors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
elliptical cnfw/cnfwLudlow/cnfwLudlowScatter via mge