Fix cosmology distance cache breaking JAX JIT tracing#334
Merged
Conversation
The dist cache used float(result) to store values, which fails during JAX JIT compilation because abstract tracers cannot be converted to float. Guard both cache lookup and store with `if xp is np:` so the cache is only used on the NumPy path — JAX handles its own caching via JIT compilation. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
angular_diameter_distance_kpc_z1z2distance cache withif xp is np:so it is skipped entirely on the JAX pathfloat(result)was called on a JAX abstract tracer during JIT compilation, raisingConcretizationTypeErrorxp.asarray()wrapping on cache hit return (result is already a numpy array)Test plan
python -m pytest test_autogalaxy/ConcretizationTypeErrorin cosmology🤖 Generated with Claude Code