Conversation
added 11 commits
May 14, 2025 20:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates and refactors image-plane multiple image based positions likelihood penalty to support multiple lens planes (e.g. double einstein ring systems).
Multiple Source Plane Systems
A double source plane system is a lens system where there are multiple source-planes at different redshifts, meaning that
incuding the image-plane there are at least 3 planes.
The
PositionsLHclass can have aplane_redshiftinput, which specifies the redshift of the source-planethe positions are ray-traced to.
Multiple
PositionsLHobjects can be passed to theAnalysisobject, which then applies the penalty term toboth source-planes independently such that a double source-plane system can be fitted with the penalty based likelihood
functionality.
To set up an
Analysisobject with multiplePositionsLHobjects from a result, each positions likelihood iscomputed from the result for each
plane_redshift: