Plot improvements: critical curves once, plane_image_from, source vmax#409
Merged
Plot improvements: critical curves once, plane_image_from, source vmax#409
Conversation
- Compute critical curves / caustics once in PlotterImaging.fit_imaging() and pass down to subplot_fit, subplot_fit_log10, and subplot_tracer_from_fit, eliminating redundant recomputation - Move plane_image_from to tracer_plots.py; implement zoom_to_brightest by evaluating parametric source light profiles on a uniform grid (fit.mask.derive_grid.all_false) rather than a ray-traced grid - Add vmax parameter to _plot_source_plane and pass source_vmax to Source Plane (Zoomed) and Source Plane (No Zoom) panels in subplot_fit, subplot_fit_log10, and subplot_tracer_from_fit so they share the same colorbar scale as the Data (Source Scale) panel Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlotterImaging.fit_imaging()and pass down tosubplot_fit,subplot_fit_log10, andsubplot_tracer_from_fit, eliminating redundant recomputationplane_image_fromtotracer_plots.py; implementzoom_to_brightestfor parametric sources by evaluating light profiles on a plain uniform grid (fit.mask.derive_grid.all_false) rather than a ray-traced grid, showing the source without lensing distortionvmaxto_plot_source_planeand passsource_vmaxto Source Plane (Zoomed) and Source Plane (No Zoom) panels insubplot_fit,subplot_fit_log10, andsubplot_tracer_from_fitso they share the same colorbar scale as the Data (Source Scale) panelTest plan
scripts/imaging/visualization.py— verifyfit.pngsource-plane panels use samevmaxas Data (Source Scale)tracer.pngSource Plane (No Zoom) matches Source Model Image colorbar scalefit_imaging()call (no performance regression)🤖 Generated with Claude Code