fix: PYAUTO_DISABLE_JAX env var was being overridden#425
Merged
Conversation
…x assignment AnalysisDataset.__init__ had `self._use_jax = use_jax` at line 112 which overwrote the env var check in Analysis.__init__. This meant PYAUTO_DISABLE_JAX=1 had no effect — JAX JIT compilation still ran, adding ~3.5s of overhead per likelihood evaluation. Fix: apply the env var check at the top of AnalysisDataset.__init__ before passing use_jax to super(). Remove the stale override (its comment said "Can be deleted after relevant AutoFIT PR merged" — PR #1184 is now merged). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AnalysisDataset.__init__hadself._use_jax = use_jaxwhich overwrote the env var check inAnalysis.__init__. This meantPYAUTO_DISABLE_JAX=1had no effect — JAX JIT compilation still ran, adding ~3.5s per likelihood evaluation during smoke tests.Fix: apply the env var check before passing
use_jaxtosuper(), and remove the stale override (its comment said "Can be deleted after relevant AutoFIT PR merged" — PR #1184 is now merged).API Changes
None — bug fix only.
Test Plan
imaging/modeling.pysearch.fit: 5.9s → 0.6s🤖 Generated with Claude Code