fix: VRAM timing notes and interferometer modeling bug fix#35
Merged
fix: VRAM timing notes and interferometer modeling bug fix#35
Conversation
- Add "takes about 20-30 seconds" note to all print_vram_use comments that were missing it (8 scripts) - Fix bug in interferometer/modeling.py line 477: fit=fit changed to fit=result.max_log_likelihood_fit (undefined variable) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Jammy2211
added a commit
that referenced
this pull request
Apr 9, 2026
fix: VRAM timing notes and interferometer modeling bug fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add consistent VRAM timing notes to all
print_vram_usecomments and fix undefined variable bug in interferometer modeling script.Scripts Changed
scripts/imaging/features/advanced/double_einstein_ring/modeling.py— added VRAM timing notescripts/imaging/features/advanced/mass_stellar_dark/modeling.py— added VRAM timing notescripts/imaging/features/pixelization/delaunay.py— added VRAM timing notescripts/imaging/features/pixelization/modeling.py— added VRAM timing notescripts/interferometer/features/pixelization/delaunay.py— added VRAM timing notescripts/interferometer/features/pixelization/modeling.py— added VRAM timing notescripts/interferometer/modeling.py— fixedfit=fit→fit=result.max_log_likelihood_fit(line 477)scripts/multi/modeling.py— added VRAM timing notescripts/point_source/modeling.py— added VRAM timing noteUpstream PRs
Test Plan
🤖 Generated with Claude Code