Use should_simulate in JAX auto-simulation blocks#14
Merged
Conversation
Replace path.exists checks with should_simulate so that datasets are automatically deleted and re-created when PYAUTO_WORKSPACE_SMALL_DATASETS is toggled, preventing shape mismatches between FITS files and masks. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
not path.exists(dataset_path)withal.util.dataset.should_simulate(dataset_path)in all 13 JAX likelihood function scripts. This ensures datasets are automatically deleted and re-created whenPYAUTO_WORKSPACE_SMALL_DATASETSis toggled, preventing shape mismatches between FITS files and masks.Scripts Changed
scripts/jax_likelihood_functions/imaging/lp.py— use should_simulatescripts/jax_likelihood_functions/imaging/mge.py— samescripts/jax_likelihood_functions/imaging/mge_group.py— samescripts/jax_likelihood_functions/imaging/delaunay.py— samescripts/jax_likelihood_functions/imaging/delaunay_mge.py— samescripts/jax_likelihood_functions/imaging/rectangular.py— samescripts/jax_likelihood_functions/imaging/rectangular_mge.py— samescripts/jax_likelihood_functions/imaging/rectangular_dspl.py— samescripts/jax_likelihood_functions/interferometer/mge.py— samescripts/jax_likelihood_functions/interferometer/rectangular.py— samescripts/jax_likelihood_functions/interferometer/mge_group.py— samescripts/jax_likelihood_functions/point_source/point.py— same (pathlib → str conversion)scripts/jax_likelihood_functions/multi/mge.py— sameUpstream PRs
Test Plan
🤖 Generated with Claude Code