Conversation
thetazero
left a comment
thetazero
left a comment
There was a problem hiding this comment.
Looks solid, I think it should work (you should still test this).
Noticed two small details I was confused about.
| } | ||
|
|
||
| # SIG = bytearray.fromhex("FF") | ||
| SIG = bytearray(1) |
There was a problem hiding this comment.
These are specific bytes in the JPEG file format. All JPEG's start and end with the same bytes
| Messages must support the `__lt__`, `__le__`, `__eq__`, `__ge__`, and `__gt__` operators. | ||
| This enables to the max heap to compare messages based on their priority. | ||
| """ | ||
| from .queue import Queue |
There was a problem hiding this comment.
you definitely just coppied this from the other queue, but this is probably a bad idea to add all this boiler plate just to make a slightly easier import.
At least on the pycubed-mini side we started having memory issues and stuff like this doesn't help.
Not at all your fault given this is how it's done else where. I'd either just make it the three lines needed ie:
from .queue import Queue
limit = 100
image_queue = Queue(limit)Or leave a issue somewhere to do this later (so we don't forget).
There was a problem hiding this comment.
I agree with Losha here, We could make this a much smaller file.
tomyyyD
left a comment
tomyyyD
left a comment
There was a problem hiding this comment.
The more I read through this code, the more I realize that I left it in a 3/4 finished state over the summer. I'd like to go over some of this with you tmrw at the lab.
| } | ||
|
|
||
| # SIG = bytearray.fromhex("FF") | ||
| SIG = bytearray(1) |
There was a problem hiding this comment.
These are specific bytes in the JPEG file format. All JPEG's start and end with the same bytes
| Messages must support the `__lt__`, `__le__`, `__eq__`, `__ge__`, and `__gt__` operators. | ||
| This enables to the max heap to compare messages based on their priority. | ||
| """ | ||
| from .queue import Queue |
There was a problem hiding this comment.
I agree with Losha here, We could make this a much smaller file.
| return False, None | ||
|
|
||
| async def request_image(radio, debug=False): | ||
| # Notice: response is never used |
There was a problem hiding this comment.
Response is used within the send_command function.
3 participants
A version of radio_modes branch for the ground station that now has the ability to request images from the satellite. Based on the a mix of the image requesting implementation from both the image_loop and implementing_LoRa branches.
The ground station is now able to store more than one image based on the time stamp found in gs_commands.py. I considered having it search through local files to find the most recent file however I felt opposed to that idea and included an additional variable that essentially keeps track of the file path.