Open
Conversation
jbwillis
requested changes
Dec 19, 2023
Contributor
jbwillis
left a comment
jbwillis
left a comment
There was a problem hiding this comment.
Headed in the right direction, comments are mostly regarding getting it integrated into the rest of the pygnc system.
If you're having issues with the imports resolving while running it, let me know.
| @@ -0,0 +1,25 @@ | |||
| # from ..configuration.pygnc import batch_range_filepath | |||
|
|
|||
| # print(f"Open {batch_range_filepath}") | |||
Contributor
There was a problem hiding this comment.
use this as the filepath to open
| output_file = 'sparse_measurements.bin' | ||
|
|
||
| # Replace 100 and 5 with your desired values for D and S | ||
| D = 120 # Number of bytes to read and save |
Contributor
There was a problem hiding this comment.
put these constants in ../configuration/range_history_saver.py
Contributor
There was a problem hiding this comment.
Also reference Py4Data/example_range_parse/dataparser_range.py to get the correct value for D (it's not 120).
| count += 1 | ||
| if count % S == 0: | ||
| outfile.write(data) | ||
|
|
Contributor
There was a problem hiding this comment.
Create a main() function that pulls in the correct constants and calls read_and_save().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added reading ranging + gps measurements. Also saves measurements every 30 minutes to new file