-
Notifications
You must be signed in to change notification settings - Fork 550
Ipopt_v2: update options processing #3693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
for ext in ('.nl', '.row', '.col', '.sol', '.opt'): | ||
if os.path.exists(basename + ext): | ||
raise RuntimeError( | ||
f"Solver interface file {basename + ext} already exists!" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the funny/snarky message about cowardly abandoning all hope?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's more "cowardly refusing to proceed" than "abandoning all hope".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that one ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is perfectly fine as-is but had some comments that Tuesday-morning-brain needed to get out.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3693 +/- ##
==========================================
+ Coverage 89.19% 89.22% +0.02%
==========================================
Files 892 892
Lines 103015 103256 +241
==========================================
+ Hits 91888 92127 +239
- Misses 11127 11129 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes # .
Summary/Motivation:
@eslickj pointed out two problems with the new
contrib.solver
Ipopt interface:OF_
options that the original ipopt interface supported.This PR resolves both of those issues:
OF_*
optionstime_limit
option overrides the ipopt-specificmax_cpu_time
optionChanges proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: