Change how available and license work in new solver interfaces
#3743
+665
−215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmundt
changed the title
available and license work in new solver interfaces
michaelbynum
reviewed
Oct 4, 2025
| NotFound = 0 | ||
| BadVersion = -1 | ||
| BadLicense = -2 | ||
| NeedsCompiledExtension = -3 |
There was a problem hiding this comment.
Why throw out NeedsCompiledExtension? I could definitely see us using this occasionally. I don't think there is a current use case. I guess we could easily add it back in if needed?
There was a problem hiding this comment.
We aren't using it currently so I took it out. We have no issues adding it back in if it actually becomes a valid case again.
| vtype=vtype, | ||
|
|
||
| # Acquire a Gurobi env for the duration of solve (opt + postsolve): | ||
| with self.license(): |
There was a problem hiding this comment.
Will this release the license even if the user called acquire on their own?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes None (but is part of #3688)
Summary/Motivation:
As part of the solver redesign effort, we decided to change how
availableand licensing in general will work in the new solver interface paradigm. This implements the most recent comment in #3688 for all existing solvers.Changes proposed in this PR:
availablebasically meanslicenseattribute to each solver (default is no operation)Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: