Switch to basedpyright for typechecking/LSP

README.md

@@ -3,7 +3,6 @@
 [![Build Status](https://img.shields.io/pypi/v/optional.py.svg)](https://pypi.org/project/optional.py/)
 [![test](https://github.com/Python-Optional/optional.py/actions/workflows/test.yaml/badge.svg)](https://github.com/Python-Optional/optional.py/actions/workflows/test.yaml)
 [![lint](https://github.com/Python-Optional/optional.py/actions/workflows/lint.yaml/badge.svg)](https://github.com/Python-Optional/optional.py/actions/workflows/lint.yaml)
-[![typecheck](https://github.com/Python-Optional/optional.py/actions/workflows/typecheck.yaml/badge.svg)](https://github.com/Python-Optional/optional.py/actions/workflows/typecheck.yaml)
 [![format](https://github.com/Python-Optional/optional.py/actions/workflows/format.yaml/badge.svg)](https://github.com/Python-Optional/optional.py/actions/workflows/format.yaml)
 [![editorconfig](https://github.com/Python-Optional/optional.py/actions/workflows/editorconfig.yaml/badge.svg)](https://github.com/Python-Optional/optional.py/actions/workflows/editorconfig.yaml)
 [![License](https://img.shields.io/pypi/l/optional.py.svg)](https://pypi.org/project/optional.py/)

justfile

@@ -6,18 +6,24 @@ commands:
 test:
     @poetry run python -m pytest
 
+# Lint source code
+[parallel]
+lint: lint-ruff lint-basedpyright
+
 # Lint code using ruff
-lint:
+[private]
+lint-ruff:
     @poetry run python -m ruff check optional tests
 
+# Lint code using basedpyright
+[private]
+lint-basedpyright:
+    @poetry run python -m basedpyright optional tests
+
 # Format code using ruff
 format:
     @poetry run python -m ruff format optional tests
 
-# Check types using mypy
-typecheck:
-    @poetry run python -m mypy optional tests
-
 # Check for editorconfig violations using editorconfig-checker
 editorconfig:
     @editorconfig-checker

optional/optional.py

@@ -21,7 +21,7 @@ def of() -> Nothing: ...
 
     @staticmethod
     @overload
-    def of(thing: None) -> Nothing: ...
+    def of(thing: None) -> Nothing: ...  # pyright: ignore[reportOverlappingOverload]
 
     @staticmethod
     @overload

optional/something.py

@@ -25,7 +25,7 @@ def __eq__(self, other: object) -> bool | NotImplementedType:
         if not isinstance(other, Something):
             return NotImplemented
 
-        return self._value == other._value
+        return self._value == other._value  # pyright: ignore[reportUnknownVariableType, reportUnknownMemberType]
 
     @override
     def __repr__(self) -> str:

pyproject.toml

@@ -4,8 +4,8 @@ version = "2.0.0"
 description = "An implementation of the Optional object in Python"
 license = "MIT"
 authors = [
-  {name = "Chad Befus", email = "crbefus@gmail.com"},
-  {name = "Derek Passen", email = "dpassen1@gmail.com"}
+  { name = "Chad Befus", email = "crbefus@gmail.com" },
+  { name = "Derek Passen", email = "dpassen1@gmail.com" },
 ]
 readme = "README.md"
 repository = "https://github.com/Python-Optional/optional.py"
@@ -14,22 +14,18 @@ keywords = ["optional datatype library"]
 requires-python = ">= 3.10"
 
 [project.optional-dependencies]
-dev = ["ruff", "mypy"]
+dev = ["ruff", "basedpyright", "typing-extensions"]
 test = ["pytest", "pytest-cov", "coveralls", "coverage"]
 
 [tool.poetry]
-packages = [
-    { include = "optional" },
-]
+packages = [{ include = "optional" }]
 
 [tool.coverage.report]
 exclude_lines = ["@overload"]
 
 [tool.pytest.ini_options]
 addopts = "--cov=optional"
-testpaths = [
-    "tests",
-]
+testpaths = ["tests"]
 
 [tool.ruff]
 line-length = 88

tests/test_optional.py

@@ -1,3 +1,7 @@
+# pyright: reportUnnecessaryComparison=false
+# pyright: reportUnreachable=false
+# pyright: reportUnusedCallResult = false
+
 import pytest
 
 from optional import Nothing, Optional, Something

tests/test_something.py

@@ -1,3 +1,5 @@
+# pyright: reportUnusedCallResult = false
+
 import pytest
 
 from optional import Optional, Something