Fix bug in novelty check when no papers found - replace 'is None' with falsy check

[Copilot]

Problem

The check_idea_novelty function in ai_scientist/generate_ideas.py had a bug where it only checked for papers is None when handling empty search results. This could cause issues if the search_for_papers function returns other falsy values like empty lists instead of None.

Solution

Replaced the explicit None check with a more robust falsy check (if not papers:) that handles both None and empty collection cases.

Changes Made

1. ai_scientist/generate_ideas.py (line 417): Changed if papers is None: to if not papers:
2. ai_scientist/perform_writeup.py (line 321): Fixed the same pattern for consistency

Why This Fix Is Better

• More robust: Handles None, empty lists [], and other falsy values
• Consistent with Python best practices: Using falsy checks for "empty" conditions
• Future-proof: Works even if search_for_papers behavior changes to return empty lists instead of None

Testing

• ✅ Code compiles successfully: python -m py_compile ai_scientist/generate_ideas.py
• ✅ No breaking changes to existing functionality
• ✅ Follows the same pattern used elsewhere in the codebase

The search_for_papers function can return None in two cases:

1. When no query is provided (if not query: return None)
2. When no results are found (if not total: return None)

This change ensures both cases are handled consistently, preventing potential runtime errors when the function behavior changes or returns empty collections.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[bolt-new-by-stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[sourcery-ai]

🧙 Sourcery has finished reviewing your pull request!

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.