Changes #3
Changes #3
Conversation
… reasons to pay for stream (partial payment EventParticipation), so first select latest row with reason LeftPaidStream and then select all rows with reason != LeftPaidStream and with insertedTime more than prev row selected. (cherry picked from commit 8e73f427f2bc96fee88b4690a62302aa2a1f330c)
(cherry picked from commit 867d93f39e63ffbf903cf93227165fca4f0841c2)
classes/Assets/Credits.php
Outdated
| } | ||
|
|
||
| // as $joined_assets_credits ordered by insertedTime asc than the last row is the latest | ||
| $data->insertedTime = $joined_assets_credit->insertedTime; |
There was a problem hiding this comment.
It's not good to reference $joined_assets_credit which is a local variable in a loop, after loop ends. Yes this works in PHP and happens to leave it pointing to the last one, but are you sure this is what you want?
why are you making $data an StdClass() object? and then return it instead of an actual Assets_Credits row? what are you trying to accomplish here? it seems wrong. At least make it an Assets_Credits row, even though it's synthetic, so its type will match.
I guess you are trying to handle a result where multiple transfers happened after user left stream the previous time? Instead of one transfer?
I would say just change the function signature to return an array of Assets_Credits rows, and change all the callers of this method to traverse the array and do what they want (e.g. sum the amounts in all the rows).
classes/Assets/Credits.php
Outdated
| 'fromStreamName' => $fromStreamName, | ||
| 'reason' => $reasons | ||
| 'reason !=' => $leftReason, | ||
| 'insertedTime >' => $latestLeftPaidStream |
There was a problem hiding this comment.
I'd recommend using >= not > just in case
There was a problem hiding this comment.
All requested changes done.
…ymentsInfo which return all info about payments for paid stream. (cherry picked from commit 323af27dedac8e60fb343c1080b485b9003bc0b4)
2 participants
No description provided.