Skip to content

fux bitset and bitget bug when the key is expire or deleted #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fux bitset and bitget bug when the key is expire or deleted #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c899c7
fix sscan
prcyangli Jun 26, 2017
43199b1
fix setbit coredump
prcyangli Jun 27, 2017
f84fe15
fux bitset and bitget bug when the key is expire or deleted
prcyangli Feb 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/nemo_bit.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ using namespace nemo;
Status Nemo::BitSet(const std::string &key, const std::int64_t offset, const int64_t on, int64_t* res) {
std::string value;
Status s = kv_db_->Get(rocksdb::ReadOptions(), key, &value);
if (s.IsNotFound()) {
value = "";
}
if (s.ok() || s.IsNotFound()) {
size_t byte = offset >> 3;
size_t bit = 7 - (offset & 0x7);
Expand All @@ -37,7 +40,7 @@ Status Nemo::BitSet(const std::string &key, const std::int64_t offset, const int
if (byte + 1 <= value_lenth) {
value.replace(byte, 1, &byte_val, 1);
} else {
value.append(byte - value_lenth -1, 0);
value.append(byte + 1 - value_lenth -1, 0);
value.append(1, byte_val);
}
s = kv_db_->Put(rocksdb::WriteOptions(), key, value);
Expand All @@ -55,6 +58,9 @@ Status Nemo::BitSet(const std::string &key, const std::int64_t offset, const int
Status Nemo::BitGet(const std::string &key, const std::int64_t offset, std::int64_t* res) {
std::string value;
Status s = kv_db_->Get(rocksdb::ReadOptions(), key, &value);
if (s.IsNotFound()) {
value = "";
}
if (s.ok() || s.IsNotFound()) {
size_t byte = offset >> 3;
size_t bit = 7 - (offset & 0x7);
Expand Down
4 changes: 2 additions & 2 deletions src/nemo_kv.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,8 +426,8 @@ bool Nemo::ScanKeysWithTTL(std::unique_ptr<rocksdb::DBNemo>& db, std::string& st
key = it->key().ToString();
if (stringmatchlen(pattern.data(), pattern.size(), key.data(), key.size(), 0) && key.substr(0, scan_keys_store_pre.size()) != scan_keys_store_pre) {
keys.push_back(key);
(*count)--;
}
(*count)--;
it->Next();
}
if (it->Valid()) {//the scan is over in the kv_db_
Expand Down Expand Up @@ -461,8 +461,8 @@ bool Nemo::ScanKeys(std::unique_ptr<rocksdb::DBNemo>& db, const char kType, std:
if (stringmatchlen(pattern.data(), pattern.size(), key.data() + 1, key.size() - 1, 0)) {
key.erase(key.begin());//erase the first marked letter
keys.push_back(key);
(*count)--;
}
(*count)--;
it->Next();
}
if (it->Valid() && it->key().ToString().at(0) == kType) {
Expand Down