Skip to content

LO circuit cuts optimizer#471

Closed
caleb-johnson wants to merge 146 commits intomainfrom
LO-circuit-cuts-optimizer
Closed

LO circuit cuts optimizer#471
caleb-johnson wants to merge 146 commits intomainfrom
LO-circuit-cuts-optimizer

Conversation

@caleb-johnson
Copy link
Copy Markdown
Collaborator

@caleb-johnson caleb-johnson commented Jan 9, 2024

Create a subpackage, circuit_knitting.cutting.cut_finding, for users to automatically find LO gate + wire cuts, given some cut criteria.

@caleb-johnson caleb-johnson changed the title Lo circuit cuts optimizer LO circuit cuts optimizer Jan 9, 2024
@caleb-johnson caleb-johnson force-pushed the LO-circuit-cuts-optimizer branch from 4e73f2a to aa280e8 Compare January 9, 2024 15:55
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 26, 2024

Pull Request Test Coverage Report for Build 8482139047

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1036 of 1036 (100.0%) changed or added relevant lines in 13 files are covered.
  • 17 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+1.8%) to 95.383%

Files with Coverage Reduction New Missed Lines %
circuit_knitting/cutting/cutqc/wire_cutting_evaluation.py 17 83.78%
Totals Coverage Status
Change from base Build 8426627253: 1.8%
Covered Lines: 3409
Relevant Lines: 3574

💛 - Coveralls

Comment thread circuit_knitting/cutting/find_cuts.py Outdated
@ibrahim-shehzad
Copy link
Copy Markdown
Collaborator

Thoughts now on merging this PR, @garrison , @caleb-johnson ?

@caleb-johnson
Copy link
Copy Markdown
Collaborator Author

Thoughts now on merging this PR, @garrison , @caleb-johnson ?

I'll wait for you both to give the 👍 , and I'll give it one more pass before merging

@ibrahim-shehzad
Copy link
Copy Markdown
Collaborator

I think we're good to go, from my perspective.

Comment thread circuit_knitting/cutting/cutting_decomposition.py Outdated
Comment thread circuit_knitting/cutting/cut_finding/cco_utils.py Outdated
Comment thread circuit_knitting/cutting/cut_finding/cco_utils.py
Comment thread releasenotes/notes/automatic-cut-finding-696556915e347138.yaml Outdated
"""Test optimization parameters for being valid data types."""

with pytest.raises(ValueError):
_ = OptimizationSettings(max_gamma=max_gamma, max_backjumps=max_backjumps)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid to even suggest this, but I think the following would have been sufficient. No need to change this since all the linters are happy.

Suggested change
_ = OptimizationSettings(max_gamma=max_gamma, max_backjumps=max_backjumps)
OptimizationSettings(max_gamma=max_gamma, max_backjumps=max_backjumps)

Comment thread circuit_knitting/cutting/find_cuts.py
Comment thread test/cutting/test_find_cuts.py Outdated
Comment thread circuit_knitting/cutting/cutting_decomposition.py Outdated
Comment thread circuit_knitting/cutting/cut_finding/cco_utils.py Outdated
Comment thread test/cutting/test_find_cuts.py Outdated
Comment thread tox.ini Outdated
@caleb-johnson
Copy link
Copy Markdown
Collaborator Author

Closing in favor of #520

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cutting QPD-based circuit cutting code enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cut finder design decisions and to-do items.

6 participants