[codex] Ignore explicit global_phase instructions during separation#804
Draft
TSS99 wants to merge 1 commit intoQiskit:mainfrom
Draft
[codex] Ignore explicit global_phase instructions during separation#804TSS99 wants to merge 1 commit intoQiskit:mainfrom
TSS99 wants to merge 1 commit intoQiskit:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
global_phaseinstructions when assigning operations to circuit partitionsseparate_circuit()andpartition_problem()Root cause
Qiskit can materialize a circuit-level global phase as a zero-qubit
global_phaseinstruction.separate_circuit()assumed every instruction touched exactly one partition, so these zero-qubit instructions leftpartitions_spannedempty and triggered an assertion.Fix
global_phaseinstructions while partitioning operations into subcircuits_separate_instructions_by_partition()so the public APIs inherit the fix without broader refactoringTests
tox -e linttox -e py311 -- test\\utils\\test_transforms.py test\\test_cutting_decomposition.py test\\test_cutting_workflows.pyNotes or limitations
global_phaseinstruction reported in Global phase circuit instruction causespartition_problemto error. #762no-self-useremain unchangedFixes #762