Skip to content

Use machine precision as tolerance during backprop#60

Open
caleb-johnson wants to merge 2 commits intomainfrom
atol
Open

Use machine precision as tolerance during backprop#60
caleb-johnson wants to merge 2 commits intomainfrom
atol

Conversation

@caleb-johnson
Copy link
Copy Markdown
Collaborator

@caleb-johnson caleb-johnson commented Apr 20, 2026

This PR sets atol to f64 precision during back-propagation, rather than 0.0. This can give a meaningful speedup on problems where a large number of terms with tiny coeff values accumulate in the operators.

@caleb-johnson caleb-johnson requested a review from mrossinek April 20, 2026 18:33
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 20, 2026

Coverage Report for CI Build 24684137996

Coverage decreased (-0.06%) to 74.627%

Details

  • Coverage decreased (-0.06%) from the base build.
  • Patch coverage: 1 uncovered change across 1 file (1 of 2 lines covered, 50.0%).
  • 1 coverage regression across 1 file.

Uncovered Changes

File Changed Covered %
qiskit_addon_slc/bounds/backward.py 2 1 50.0%

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
qiskit_addon_slc/bounds/backward.py 1 60.0%

Coverage Stats

Coverage Status
Relevant Lines: 804
Covered Lines: 600
Line Coverage: 74.63%
Coverage Strength: 0.75 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants