Fix lightcone pass mid circuit measurements#16046
Open
CosminDinuThiery wants to merge 9 commits intoQiskit:mainfrom
Open
Fix lightcone pass mid circuit measurements#16046CosminDinuThiery wants to merge 9 commits intoQiskit:mainfrom
CosminDinuThiery wants to merge 9 commits intoQiskit:mainfrom
Conversation
Collaborator
|
Thanks for the contribution! The approach looks good here, though we need more testing here, mainly to cover 2 newly unlocked cases:
We can't backport this PR since it adds the Pauli product handling as new feature. Would you mind splitting this PR into two, where (1) handles mid-circuit measurements only (this we can backport as fix), and (2) adds Pauli-product support (this is a new feature). |
Contributor
Author
|
Alright, I will take care of that by tomorrow, thank you for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #15937. The LightCone pass was using calc_final_ops to find measured qubits, which
only detects final measurements and ignored mid-circuits.
Details and comments
I removed _find_measurement_qubits and replaced it with detection of standard and PauliProductMeasurement gates during the reverse-topological traversal, as suggested in the issue.
Also, _measurement_commutation_ops accesses private attributes _pauli_z and _pauli_x of PauliProductMeasurement
AI/LLM disclosure