-
Notifications
You must be signed in to change notification settings - Fork 27
feat(alert): add support for alert email notification channel #2327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Conversation
|
Qovery can create a Preview Environment for this PR.
This comment has been generated from Qovery AI 🤖.
|
576731b to
3ec8bfa
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #2327 +/- ##
===========================================
+ Coverage 47.53% 49.74% +2.21%
===========================================
Files 1279 405 -874
Lines 23524 9365 -14159
Branches 6931 2853 -4078
===========================================
- Hits 11182 4659 -6523
+ Misses 10191 3792 -6399
+ Partials 2151 914 -1237
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3ec8bfa to
764981d
Compare
8eaa60e to
91b6a65
Compare
d1605b5 to
831937f
Compare
|
|
||
| type AlertReceiverFormData = SlackFormData | EmailFormData | ||
|
|
||
| const validateSlackForm = (values: SlackFormData, isEdit: boolean) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of having these 2 functions (validateSlackForm and validateEmailForm), could you use inline validation offered by React Hook Form ?
You will find an example here:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
5e7f6a0 to
8bb8af0
Compare
8bb8af0 to
ac7d8fc
Compare
Summary
Allow to add some email notification channel for alerting
preview env: http://localhost:4200/organization/460616f0-94da-4d35-b631-6fa4ed08eb9a/alerting/notification-channel
figma: https://www.figma.com/design/niVXkQbcNBbaXxmhemiIy1/Alerting?node-id=338-588407&p=f
UX review: https://qovery.slack.com/archives/C090XR4CA69/p1769431524167739?thread_ts=1769073337.693549&cid=C090XR4CA69
Issue:
Screenshots / Recordings
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release