Skip to content

Conversation

@pggb25
Copy link
Collaborator

@pggb25 pggb25 commented Jan 23, 2026

Summary

Allow to add some email notification channel for alerting
preview env: http://localhost:4200/organization/460616f0-94da-4d35-b631-6fa4ed08eb9a/alerting/notification-channel

figma: https://www.figma.com/design/niVXkQbcNBbaXxmhemiIy1/Alerting?node-id=338-588407&p=f

UX review: https://qovery.slack.com/archives/C090XR4CA69/p1769431524167739?thread_ts=1769073337.693549&cid=C090XR4CA69

Issue:

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet
Copy link
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

There is no better time than now, better future does not exist

@pggb25 pggb25 force-pushed the feat/alert-email-2 branch 2 times, most recently from 576731b to 3ec8bfa Compare January 23, 2026 17:46
@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 61.95652% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.74%. Comparing base (c81f0a5) to head (ac7d8fc).
⚠️ Report is 4 commits behind head on staging.

Files with missing lines Patch % Lines
...ation-channel-modal/notification-channel-modal.tsx 62.82% 24 Missing and 5 partials ⚠️
...channel-overview/notification-channel-overview.tsx 66.66% 3 Missing and 1 partial ⚠️
...c-configuration-step/metric-configuration-step.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2327      +/-   ##
===========================================
+ Coverage    47.53%   49.74%   +2.21%     
===========================================
  Files         1279      405     -874     
  Lines        23524     9365   -14159     
  Branches      6931     2853    -4078     
===========================================
- Hits         11182     4659    -6523     
+ Misses       10191     3792    -6399     
+ Partials      2151      914    -1237     
Flag Coverage Δ
unittests 49.74% <61.95%> (+2.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pggb25 pggb25 force-pushed the feat/alert-email-2 branch from 3ec8bfa to 764981d Compare January 23, 2026 18:13
@pggb25 pggb25 changed the base branch from staging to feat/alert-email January 26, 2026 08:22
@pggb25 pggb25 changed the title Feat/alert email 2 feat(alert): add support for alert email notification channel Jan 26, 2026
Base automatically changed from feat/alert-email to staging January 26, 2026 09:49
@pggb25 pggb25 force-pushed the feat/alert-email-2 branch 2 times, most recently from d1605b5 to 831937f Compare January 26, 2026 16:04

type AlertReceiverFormData = SlackFormData | EmailFormData

const validateSlackForm = (values: SlackFormData, isEdit: boolean) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having these 2 functions (validateSlackForm and validateEmailForm), could you use inline validation offered by React Hook Form ?

You will find an example here:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@pggb25 pggb25 force-pushed the feat/alert-email-2 branch from 5e7f6a0 to 8bb8af0 Compare January 27, 2026 16:44
@pggb25 pggb25 force-pushed the feat/alert-email-2 branch from 8bb8af0 to ac7d8fc Compare January 27, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants