-
Notifications
You must be signed in to change notification settings - Fork 27
feat: add UI for disk IOPS and throughput configuration on AWS nodepools #2330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Conversation
|
Qovery can create a Preview Environment for this PR.
This comment has been generated from Qovery AI 🤖.
|
aff8592 to
ea38433
Compare
Add user interface for configuring IOPS and throughput on AWS EBS gp3 volumes for cluster nodepools. Changes: - Add disk_iops and disk_throughput to ClusterResourcesData and KarpenterData interfaces - Add IOPS/throughput input fields in cluster resources settings (non-Karpenter, Karpenter stable, Karpenter GPU) - Update cluster creation flow to include IOPS/throughput in API requests - Update cluster edit flow to handle IOPS/throughput updates - Add default values in cluster factory mocks for testing - Fields are optional and only displayed for AWS clusters The UI provides hints for valid value ranges: - IOPS: 3000-16000 for EBS gp3 - Throughput: 125-1000 MB/s for EBS gp3
Update hints for disk IOPS and throughput fields to indicate they are only available with AWS EBS gp3 storage class. This provides better user guidance and prevents configuration errors.
Add extended interfaces to support disk_iops and disk_throughput fields for cluster nodepools and Karpenter GPU nodes until the API client is regenerated with the latest backend schema. - ClusterExtended: extends Cluster with disk_iops and disk_throughput - ClusterFeatureKarpenterParametersExtended: extends Karpenter params - KarpenterGpuNodePoolOverrideExtended: extends GPU override with IOPS/throughput
Use ClusterKeda type from qovery-typescript-axios instead of custom interface to maintain consistency with generated API types.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #2330 +/- ##
===========================================
- Coverage 47.59% 47.50% -0.09%
===========================================
Files 1256 1242 -14
Lines 23027 22584 -443
Branches 6745 6635 -110
===========================================
- Hits 10959 10728 -231
+ Misses 9977 9778 -199
+ Partials 2091 2078 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ea38433 to
13f66a2
Compare
…ss mention Remove 'Only available with gp3 storage class' from form hints as gp3 is the default storage class, making the UI lighter and cleaner.
| } | ||
|
|
||
| // Extended Cluster type with disk_iops and disk_throughput fields | ||
| // These will be available once the API client is regenerated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Guimove Instead of overriding existing TS interfaces, changes need to be made to the OpenAPI spec in order to reflect these new fields. The OpenAPI spec is our source of truth.

Add user interface for configuring IOPS and throughput on AWS EBS gp3 volumes for cluster nodepools.
Changes:
The UI provides hints for valid value ranges:
Summary
Issue:
Screenshots / Recordings
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release