Skip to content

fix(keda): adapt message to keda and hpa setting #2336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pggb25 merged 1 commit into from
Jan 27, 2026
+16 −56
Merged

fix(keda): adapt message to keda and hpa setting #2336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions libs/domains/services/feature/src/lib/keda/components/keda-settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,18 +35,6 @@ export function KedaSettings({
requireMinLessThanMax={true}
/>

<Callout.Root color="sky" className="mt-3">
<Callout.Icon>
<Icon iconName="circle-info" iconStyle="regular" />
</Callout.Icon>
<Callout.Text>
<p>
For applications requiring high availability, set Minimum Instances to at least 2 to maintain service
availability during pod failures or cluster maintenance.
</p>
</Callout.Text>
</Callout.Root>

<KedaScalersFields control={control} scalersFieldArray={scalersFieldArray} disabled={disabled} />
</>
)
Expand Down
26 changes: 0 additions & 26 deletions ...on/src/lib/ui/page-settings-resources/__snapshots__/page-settings-resources.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,32 +334,6 @@ exports[`PageSettingsResources should render warning box and icon for cpu 1`] =
</div>
</div>
</div>
<div
class="flex flex-row gap-x-3 p-3 border rounded text-sm border-yellow-600 bg-yellow-50 text-yellow-700 mt-3"
data-accent-color="yellow"
>
<div
class="-order-2 text-lg leading-6"
>
<i
aria-hidden="true"
class="fa-regular fa-triangle-exclamation "
/>
</div>
<div
class="-order-1 mr-auto gap-x-3 text-neutral-400"
>
<p>
Always assume one instance may fail due to node maintenance or issues.
</p>
<p>
To ensure high availability, set Minimum Instances to 2 if your app can run on 1 instance.
</p>
<p>
If your application requires more than one instance to handle necessary traffic, set the minimum to 3 or higher to guarantee redundancy during a single failure.
</p>
</div>
</div>
<div
class="mb-5"
>
Expand Down
34 changes: 16 additions & 18 deletions ...d/src/lib/application-settings/ui/application-settings-resources/hpa-autoscaling-mode.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,11 @@ export function HpaAutoscalingMode({
maxInstances,
minRunningInstances,
hpaMetricType,
hpaAverageUtilizationPercent,
hpaMemoryAverageUtilizationPercent,
runningPods,
environmentMode,
}: HpaAutoscalingModeProps) {
const isProduction = environmentMode === EnvironmentModeEnum.PRODUCTION
const hasSingleInstance = minRunningInstances === 1
const hasSingleInstance = minRunningInstances <= 1

return (
<>
Expand All @@ -43,25 +41,25 @@ export function HpaAutoscalingMode({
requireMinLessThanMax={true}
/>

<Callout.Root color="yellow" className="mt-3">
<Callout.Icon>
<Icon iconName="triangle-exclamation" iconStyle="regular" />
</Callout.Icon>
<Callout.Text>
<p>Always assume one instance may fail due to node maintenance or issues.</p>
<p>To ensure high availability, set Minimum Instances to 2 if your app can run on 1 instance.</p>
<p>
If your application requires more than one instance to handle necessary traffic, set the minimum to 3 or
higher to guarantee redundancy during a single failure.
</p>
{isProduction && hasSingleInstance && (
{isProduction && hasSingleInstance && (
<Callout.Root color="yellow" className="mt-3">
<Callout.Icon>
<Icon iconName="triangle-exclamation" iconStyle="regular" />
</Callout.Icon>
<Callout.Text>
<p>Always assume one instance may fail due to node maintenance or issues.</p>
<p>To ensure high availability, set Minimum Instances to 2 if your app can run on 1 instance.</p>
<p>
If your application requires more than one instance to handle necessary traffic, set the minimum to 3 or
higher to guarantee redundancy during a single failure.
</p>
<p className="mt-2 font-medium">
We strongly discourage running your production environment with only one instance. This setup might create
service downtime in case of cluster upgrades.
</p>
)}
</Callout.Text>
</Callout.Root>
</Callout.Text>
</Callout.Root>
)}

<HpaMetricFields control={control} setValue={setValue} hpaMetricType={hpaMetricType} />
</>
Expand Down