Conversation
and integrate the two versions of `_vertex_enumeration_producer`
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new 2-player Nash equilibrium solver based on vertex enumeration (ported from QuantEcon.py), integrating Polyhedra/CDDLib incidence information and exposing the new API through exports, docs, and tests.
Changes:
- Introduces
vertex_enumeration/vertex_enumeration_taskand supporting polytope/labeling machinery. - Adds a dedicated test suite for vertex enumeration and wires it into
runtests.jl. - Updates documentation autodocs pages and adjusts dependencies/compat for required CDDLib functionality.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/vertex_enumeration.jl |
Implements vertex enumeration algorithm, best-response polytope construction, and labeling-based matching. |
src/GameTheory.jl |
Loads and exports the new vertex enumeration API (and adds Markdown import). |
test/test_vertex_enumeration.jl |
Adds coverage for nondegenerate/degenerate games and BestResponsePolytope labeling behavior. |
test/runtests.jl |
Includes the new vertex enumeration tests in the test runner. |
docs/src/lib/computing_nash_equilibria.md |
Adds vertex_enumeration.jl to autodocs pages. |
Project.toml |
Adds Markdown and tightens CDDLib compat to 0.10.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Julia translation of quantecon/game_theory/vertex_enumeration.py (AI assisted, mainly for design discussion)
@shizejin @samwycherley Thanks for the PRs (#64, #155). I propose to merge this one and close the earlier PRs. This
O(V1 + V2); see RFC: game_theory: Use numba.typed.Dict in_vertex_enumeration_genQuantEcon.py#766) instead of linear search (0(V_1 * V_2)); andCDDLib.jlfeature for obtaining vertex-halfspace incidence information.Close #43, close #64, close #155