Agent firewall long hostname crash #559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Long hostnames result in qubesdb paths that exceed the current 64 character limit. Instead of crashing the firewall daemon, log the error and continue without adding the hostname to the DNS records. This is a workaround, not a fix, for https://github.com/QubesOS/qubes-issues/9084. The fix requires either longer path support in qubesdb or using a different schema so that keys will not exceed the qubesdb path length limit.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #559 +/- ##
==========================================
+ Coverage 70.46% 70.68% +0.22%
==========================================
Files 3 3
Lines 474 481 +7
==========================================
+ Hits 334 340 +6
- Misses 140 141 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Mar 14, 2025
Merged
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031619-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025021804-4.3&flavor=update
Failed tests15 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/129058#dependencies 6 fixed
Unstable testsPerformance TestsPerformance degradation:30 performance degradations
Remaining performance tests:42 tests
|
This was referenced Mar 14, 2025
Merged
marmarek
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long hostnames result in qubesdb paths that exceed the current 64 character limit. Instead of crashing the firewall daemon, log the error and continue without adding the hostname to the DNS records.
This is a workaround, not a fix, for QubesOS/qubes-issues#9084. The fix requires either longer path support in qubesdb or using a different schema so that keys will not exceed the qubesdb path length limit.