Skip to content

Conversation

@3nprob
Copy link

@3nprob 3nprob commented Jun 22, 2025

Refactor archlinux package by breaking out qubes-vm-nautilus from qubes-vm-core.

This matches existing Debian and Fedora packaging.

Related:


The same could also be done for -thunar and -caja. With a tentative approval here I could address those as well, in this PR or separately.

package_qubes-vm-nautilus() {
pkgdesc="Qubes OS Nautilus addons for inter-VM file copy/move/open"
arch=("any")
conflicts=('qubes-vm-core<4.3.20')
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conflicts here is due to overlapping with older versions of qubes-vm-core and I guess exact version to put depends on at what point this would get merged and released.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is being adjusted in #591

@3nprob 3nprob changed the title arch: brak out qubes-vm-nautilus from qubes-vm-core arch: break out qubes-vm-nautilus from qubes-vm-core Jun 22, 2025
@3nprob 3nprob force-pushed the arch-nautilus-package branch 4 times, most recently from ad7e22a to fe2d642 Compare June 22, 2025 02:29
@marmarek
Copy link
Member

CI says it fails to build...

@3nprob 3nprob force-pushed the arch-nautilus-package branch 3 times, most recently from 4c62fbb to 2c5e70a Compare June 23, 2025 08:39
@3nprob

This comment was marked as resolved.

@codecov
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.10%. Comparing base (a405f61) to head (3a6b3f2).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #586   +/-   ##
=======================================
  Coverage   71.10%   71.10%           
=======================================
  Files           3        3           
  Lines         481      481           
=======================================
  Hits          342      342           
  Misses        139      139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@marmarek marmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks okay, set to non-draft when you think it's ready for re-review/merge

@3nprob
Copy link
Author

3nprob commented Jun 28, 2025

looks okay, set to non-draft when you think it's ready for re-review/merge

Ty! Just rebased on master and bumped the conflicts version constraint on qubes-vm-core.

@3nprob 3nprob marked this pull request as ready for review June 28, 2025 04:34
@3nprob 3nprob force-pushed the arch-nautilus-package branch from 2c5e70a to dd194c3 Compare June 28, 2025 04:46
@3nprob 3nprob force-pushed the arch-nautilus-package branch from dd194c3 to 3a6b3f2 Compare June 28, 2025 05:38
@marmarek marmarek merged commit 3a6b3f2 into QubesOS:main Jul 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants