Trim filesystems after TemplateVM update #619
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #619 +/- ##
=======================================
Coverage 71.10% 71.10%
=======================================
Files 3 3
Lines 481 481
=======================================
Hits 342 342
Misses 139 139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| # perform fstrim on all partitions after finishing update-related I/O | ||
|
|
||
| # abort if not in a template | ||
| if [ "$(qubesdb-read /type)" = "TemplateVM" ] |
There was a problem hiding this comment.
Maybe better check /qubes-vm-persistence to be full, or simply check for /run/qubes/persistent-full existence? It would then cover standalone qubes too.
There was a problem hiding this comment.
Done. Force-pushed and tested.
After most update processes are finished, templates can benefit from performing an fstrim operation due to the large amounts of writes performed during the update process. Signed-off-by: Atrate <Atrate@protonmail.com>
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025110502-4.3&flavor=pull-requests Test run included the following:
Upload failures
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update
Failed tests16 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/149225#dependencies 82 fixed
Unstable testsPerformance TestsPerformance degradation:17 performance degradations
Remaining performance tests:161 tests
|
3 participants
After most update processes are finished, templates can benefit from performing an fstrim operation due to the large amounts of writes performed during the update process.
Fixes: QubesOS/qubes-issues#5055