Skip to content

Send optimized icon size #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2025
Merged

Send optimized icon size #249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions window-icon-updater/icon-sender
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,18 @@ import time
import xcffib
from xcffib import xproto

ICON_MAX_SIZE = 256
ICON_MAX_SIZE = 1024
# Chronological order of preferred icon sizes based on certified HW and defaults
ICON_PREFERRED_SIZES = (
(128, 128),
(96, 96),
(64, 64),
(48, 48),
(256, 256),
(512, 512),
(32, 32),
)

IconPixmapHint = 0b1 << 2
IconMaskHint = 0b1 << 5

Expand Down Expand Up @@ -247,7 +258,13 @@ class IconRetriever(object):
def describe_icon(self, w):
try:
icons = self.get_icons(w)
chosen_size = sorted(icons.keys())[-1]
# Override the largest icon with our preferred sizes (if possible)
for size in ICON_PREFERRED_SIZES:
if size in icons.keys():
chosen_size = size
break
else:
chosen_size = sorted(icons.keys())[-1]

data = b''
data += "{}\n".format(w).encode('ascii')
Expand Down