Conversation
ryanmartinneutrino
left a comment
ryanmartinneutrino
left a comment
There was a problem hiding this comment.
See error pointed out in comment and corresponding fix.
qexpy/utils/__init__.py
Outdated
|
|
||
| if "ipykernel" in sys.modules: # pragma: no cover | ||
| IPython.get_ipython().magic("matplotlib inline") | ||
| IPython.get_ipython().run_line_magic("matplotlib", "inline") |
There was a problem hiding this comment.
| IPython.get_ipython().run_line_magic("matplotlib", "inline") | |
| get_ipython().run_line_magic("matplotlib", "inline") |
There was a problem hiding this comment.
yup, I had tried that as a fix and it worked.
Should we then require a minimum version of IPython during the pip install process, to make sure that run_line_magic() is defined?
There was a problem hiding this comment.
Probably not necessary, according to this https://stackoverflow.com/questions/32681203/ipython-set-up-magic-commands-in-configuration-file?utm_source=chatgpt.com, the run_line_magic has been the standard since 10 years ago.
There was a problem hiding this comment.
Also I don't think ipython should be a dependency of qexpy, since none of the qexpy features actually requires ipython to run.
2 participants
Fixes #81