fix(sql): use AST-based statement type detection for isSelectQuery

[veksen]

Summary

• Uses analysis.statementType from @query-doctor/core (AST-based) to determine isSelectQuery instead of the regex /select/i
• The unanchored regex matched SELECT anywhere in the query, misclassifying UPDATE/INSERT/DELETE queries that contain SELECT subqueries (e.g. UPDATE ... FROM (SELECT ...))
• Falls back to an anchored regex ^\s*select for skipped queries (>50KB) where analysis is not available
• Adds 6 new tests covering DML with SELECT subqueries and analyze()-based detection

Dependencies

Requires @query-doctor/core >= 0.8.1 which adds statementType: StatementType to AnalysisResult. Companion PR: Query-Doctor/Site#2710.

Why the regex existed

CTE queries like WITH cte AS (...) SELECT ... start with WITH, not SELECT. The non-anchored regex was likely intended to catch those. The AST-based approach handles CTEs correctly because the parser identifies the outermost statement type (SelectStmt for WITH ... SELECT, UpdateStmt for WITH ... UPDATE).

Test plan

• Existing isSelectQuery tests still pass (SELECT, INSERT, UPDATE, DELETE)
• New tests verify DML with SELECT subqueries are correctly classified as non-SELECT
• New analyze() integration tests verify AST-based detection for CTE, UPDATE+subquery, INSERT...SELECT, DELETE+EXISTS
• Compat CI should pass once paired with the core PR

🤖 Generated with Claude Code

[github-actions]

Query Doctor Analysis

View full run details

83 queries analyzed

2 pre-existing issues

• SELECT "guests"."id", "guests"."session_id", "guests"."username", "guests"."avatar_path", "guests"."color", "guests"."side", "guests"."audio_recording_path", "guests"."audio_recording_public", "gue...
  index assets(event_id, inserted_at desc)
  cost 31,003,449 → 1,493 (100% reduction)
• SELECT * FROM guest_ip_addresses WHERE ip_address = '127.0.0.1';
  index guest_ip_addresses(ip_address)
  cost 154,402 → 8 (100% reduction)

_{Using assumed statistics (10000000 rows/table). For better results, sync production stats.}