Conversation
Contributor
Author
|
@sebaherrera07 build failing - will dig, but prolly not today tbh |
No hurry! Thanks! |
| s.files = Dir["{app,config,db,lib,vendor}/**/*"] + ["MIT-LICENSE", "Rakefile", "README.md"] | ||
| s.test_files = Dir["test/**/*"] | ||
|
|
||
| s.add_runtime_dependency "rails", ">= 5.0.0", "< 7.1" |
There was a problem hiding this comment.
Maybe we can set smaller supported version to Rails 6.1?.
Also the failed unit tests indicate:
ArgumentError: The `legacy_connection_handling` setter was deprecated in 7.0 and removed in 7.1, but is still defined in your configuration. Please remove this call as it no longer has any effect."
which is defined in application.rb, so we can probably get rid of that line.
Contributor
Author
There was a problem hiding this comment.
@sebaherrera07 yep, that works - we should only support current versions; I think 6.1.x is the oldest still being patched.
|
@ukd1 could you resume this fix when you have some time? And if would be nice if it supports Rails 8.0 too (instead of up to 7.2) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continuing #59 from @sebaherrera07