Skip to content

refactor(docs theme): no globalStore.theme #7645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 4, 2025
Merged

refactor(docs theme): no globalStore.theme #7645

merged 6 commits into from
Aug 4, 2025
+95 −138

Conversation

wmertens
Copy link
Member

making a PR for visibility, not quite done yet, welcome to take over from me

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 27, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b6c73aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sreeisalso
Copy link
Contributor

I have resolved the conflicts, but access denied to push the changes

@wmertens
Copy link
Member Author

wmertens commented Jun 1, 2025

@sreeisalso feel free to open a new PR with your branch, I'll close this one then.

Did you check if monaco is ok with the theme changes? (the playground)

@sreeisalso
Copy link
Contributor

@sreeisalso feel free to open a new PR with your branch, I'll close this one then.

Did you check if monaco is ok with the theme changes? (the playground)

Yes, Monaco working fine

@gioboa gioboa self-assigned this Jul 31, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 31, 2025 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview b6c73aa

@gioboa gioboa marked this pull request as ready for review August 4, 2025 07:19
@gioboa gioboa requested a review from a team as a code owner August 4, 2025 07:19
wmertens
wmertens commented Aug 4, 2025
View reviewed changes
Copy link
Member Author

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit 575d379 into build/v2 Aug 4, 2025
14 checks passed
@wmertens wmertens deleted the docs-remove-theme-store branch August 4, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreeisalso sreeisalso sreeisalso approved these changes

Assignees

@gioboa gioboa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wmertens @sreeisalso @gioboa