Skip to content

perf: scheduler and rendering improvements #7953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Sep 21, 2025
Merged

perf: scheduler and rendering improvements #7953

merged 15 commits into from
Sep 21, 2025

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Sep 14, 2025 •
edited
Loading

Performance improvements:

  • shared subscription data between rendering items
  • strong reference to element vnode instead of weak ref
  • component props diffing don't allocate new array
  • vnode as an object instead of array
  • chore array for scheduler queue
  • sync calculate wrapped signals value if possible
  • check if set or map has an item before adding or removing it

@Varixo Varixo self-assigned this Sep 14, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: c4ceaad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 14, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7953

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7953

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7953

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7953

commit: c4ceaad

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 14, 2025 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview c4ceaad

@Varixo Varixo force-pushed the v2-memory-perf branch 4 times, most recently from c57036c to 4047f19 Compare September 18, 2025 20:33
@Varixo Varixo moved this from Backlog to Waiting For Review in Qwik Development Sep 20, 2025
@Varixo Varixo marked this pull request as ready for review September 20, 2025 12:08
@Varixo Varixo requested review from a team as code owners September 20, 2025 12:08
@Varixo Varixo changed the title perf: scheduler and csr rendering improvements perf: scheduler and rendering improvements Sep 20, 2025
gioboa
gioboa approved these changes Sep 20, 2025
View reviewed changes
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You rock @Varixo 🚀

wmertens
wmertens approved these changes Sep 21, 2025
View reviewed changes
Copy link
Member

@wmertens wmertens left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit d368215 into build/v2 Sep 21, 2025
20 checks passed
@wmertens wmertens deleted the v2-memory-perf branch September 21, 2025 06:01
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Sep 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmertens wmertens wmertens approved these changes

@gioboa gioboa gioboa approved these changes

Assignees

@Varixo Varixo

Labels
VERSION: upcoming major
Projects
Qwik Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Varixo @wmertens @gioboa