Skip to content

fix(dev): use vite base in click-to-component #8187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: build/v2
Choose a base branch
from
Open

fix(dev): use vite base in click-to-component #8187

wants to merge 1 commit into from
+9 −6

Conversation

@wmertens
Copy link
Member

@wmertens wmertens commented Nov 28, 2025

fixes #8092

@wmertens wmertens requested a review from a team as a code owner November 28, 2025 05:30
@wmertens wmertens enabled auto-merge November 28, 2025 05:30
@changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: d0c137f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wmertens wmertens disabled auto-merge November 28, 2025 05:43
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 28, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8187

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8187

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8187

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8187

commit: d0c137f

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview d0c137f

@wmertens wmertens force-pushed the v2-fix-click-to-component branch from 689ffc9 to d0c137f Compare November 28, 2025 06:14
gioboa
gioboa approved these changes Nov 28, 2025
View reviewed changes
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@gioboa
Copy link
Member

gioboa commented Nov 28, 2025

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8187

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8187

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8187

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8187

commit: d0c137f

@gnemanja can you try with this release please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gioboa gioboa gioboa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wmertens @gioboa