Upkeep to satisfy CRAN checks and requests#15
Merged
RLumSK merged 7 commits intoR-Lum:masterfrom Sep 17, 2025
Merged
Conversation
This should avoid long queueing times for the old machines.
This fixes these notes: N checking R code for possible problems (4.8s) Found if() conditions comparing class() to string: File ‘RLumModel/R/read_SEQ2R.R’: if (class(file) != "character") ... File ‘RLumModel/R/simulate_CW_OSL.R’: if (class(n) != "RLum.Results") ... File ‘RLumModel/R/simulate_LM_OSL.R’: if (class(n) != "RLum.Results") ... File ‘RLumModel/R/simulate_RF.R’: if (class(n) != "RLum.Results") ... File ‘RLumModel/R/simulate_RF_and_heating.R’: if (class(n) != "RLum.Results") ... File ‘RLumModel/R/simulate_TL.R’: if (class(n) != "RLum.Results") ... File ‘RLumModel/R/simulate_heating.R’: if (class(n) != "RLum.Results") ... File ‘RLumModel/R/simulate_illumination.R’: if (class(n) != "RLum.Results") ... File ‘RLumModel/R/simulate_pause.R’: if (class(n) != "RLum.Results") ... Use inherits() (or maybe is()) instead.
This should fix this error when running the github workflow: Error: This request has been automatically failed because it uses a deprecated version of `actions/cache: v2`. Please update your workflow to use v3/v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down
This is an attempt to fix the following:
Run rcmdcheck::rcmdcheck(args = c("--no-manual", "--as-cran"),
error_on = "warning", check_dir = "check")
Error in dyn.load(file, DLLpath = DLLpath, ...) :
unable to load shared object '/home/runner/work/_temp/Library/curl/libs/curl.so':
libssl.so.1.1: cannot open shared object file: No such file or directory
Calls: loadNamespace ... asNamespace -> loadNamespace -> library.dynam -> dyn.load
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does the following: