feat: Bad mod formatting warnings

primedev/mods/modmanager.cpp

@@ -606,6 +606,40 @@ auto ModConCommandCallback(const CCommand& command)
 	};
 }
 
+void ModManager::VerifyModManifestLocation(fs::directory_entry modDir)
+{
+	if (!fs::is_directory(modDir))
+	{
+		return;
+	}
+
+	std::string filename = modDir.path().filename().generic_string().c_str();
+	// Don't display an error for hidden directories
+	if (filename.at(0) == '.')
+		return;
+
+	for (fs::directory_entry subdir : fs::recursive_directory_iterator(modDir.path()))
+	{
+		fs::path modPath = subdir.path() / "mod.json";
+		if (fs::exists(modPath))
+		{
+			spdlog::warn(
+				"mod.json file for directory {} is located at the wrong location ({}).",
+				modDir.path().generic_string().c_str(),
+				subdir.path().generic_string().c_str());
+
+			// read mod json file
+			std::ifstream jsonStream(modPath);
+			std::stringstream jsonStringStream;
+			jsonStringStream << jsonStream.rdbuf();
+			jsonStream.close();
+
+			std::shared_ptr<Mod> mod = std::shared_ptr<Mod>(new Mod(subdir, (char*)jsonStringStream.str().c_str()));
+			this->m_invalidMods.push_back(mod);
+		}
+	}
+}
+
 void ModManager::LoadMods()
 {
 	if (m_bHasLoadedMods)
@@ -642,9 +676,17 @@ void ModManager::LoadMods()
 	std::filesystem::directory_iterator remoteModsDir = fs::directory_iterator(GetRemoteModFolderPath());
 	std::filesystem::directory_iterator thunderstoreModsDir = fs::directory_iterator(GetThunderstoreModFolderPath());
 
+	this->m_invalidMods.clear();
+
 	for (fs::directory_entry dir : classicModsDir)
+	{
 		if (fs::exists(dir.path() / "mod.json"))
 			modDirs.push_back(dir.path());
+		else if (fs::is_directory(dir.path()))
+		{
+			VerifyModManifestLocation(dir);
+		}
+	}
 
 	// Special case for Thunderstore and remote mods directories
 	// Set up regex for `AUTHOR-MOD-VERSION` pattern
@@ -669,6 +711,10 @@ void ModManager::LoadMods()
 					{
 						modDirs.push_back(subDir.path());
 					}
+					else
+					{
+						VerifyModManifestLocation(subDir);
+					}
 				}
 			}
 		}

primedev/mods/modmanager.h

@@ -182,6 +182,7 @@ class ModManager
 	std::vector<Mod> m_LoadedMods;
 	std::unordered_map<std::string, ModOverrideFile> m_ModFiles;
 	std::unordered_map<std::string, std::string> m_DependencyConstants;
+	std::vector<std::shared_ptr<Mod>> m_invalidMods;
 	std::unordered_set<std::string> m_PluginDependencyConstants;
 
 public:
@@ -196,6 +197,9 @@ class ModManager
 	void TryBuildKeyValues(const char* filename);
 	void BuildPdef();
 	void BuildKBActionsList();
+
+private:
+	void VerifyModManifestLocation(fs::directory_entry modDir);
 };
 
 fs::path GetModFolderPath();