Skip to content

Conversation

@GeckoEidechse
Copy link
Member

Reverts #650 which was done due to builds failing due to madler/zlib@2e3d86c

@GeckoEidechse
Copy link
Member Author

GeckoEidechse commented Feb 4, 2024

If CI passes, this should be good to merge

EDIT: RIP

@GeckoEidechse
Copy link
Member Author

@ASpoonPlaysGames I assumed it would just pull the newest zlib version but evidently that's not the case? Or is the upstream fix not working for us?

@ASpoonPlaysGames
Copy link
Contributor

It fetches the master branch, the fix is only on develop right now

@GeckoEidechse GeckoEidechse marked this pull request as draft February 4, 2024 16:23
@GeckoEidechse GeckoEidechse force-pushed the chore/revert-zlib-cmake-fix branch from 537a340 to 60d872d Compare February 4, 2024 16:31
@GeckoEidechse
Copy link
Member Author

Yeah so develop branch works, don't think we should use that though so best to wait until merged into master ig ^^

@Alystrasz
Copy link
Member

The fix for the issue still wasn't ported to master as of today.
Commit: madler/zlib@f1f503d (Jan. 29th)
Last release: https://github.com/madler/zlib/releases/tag/v1.3.1 (Jan. 22nd)

@GeckoEidechse
Copy link
Member Author

:dread:

@Alystrasz
Copy link
Member

The fix for the issue still wasn't ported to master as of today. Commit: madler/zlib@f1f503d (Jan. 29th) Last release: https://github.com/madler/zlib/releases/tag/v1.3.1 (Jan. 22nd)

One year later, situation has not changed: v1.3.1 still is the latest zlib release. 😢

@ASpoonPlaysGames
Copy link
Contributor

Relevant issue: madler/zlib#937

@ASpoonPlaysGames
Copy link
Contributor

As of now, the situation has still not changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants