Skip to content

Conversation

@ASpoonPlaysGames
Copy link
Contributor

might work, idk

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Nov 15, 2025
@EM4Volts
Copy link
Contributor

seems to work?

@ASpoonPlaysGames
Copy link
Contributor Author

Worth noting that a crash has been observed with this PR as it currently stands. As such, marking as draft

@ASpoonPlaysGames ASpoonPlaysGames marked this pull request as draft November 28, 2025 10:40
@github-actions github-actions bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Dec 3, 2025
@EM4Volts
Copy link
Contributor

Seems to work, there is some very very edge case that i cant figure out what causes the error, but i believe that the pr can be merged, its so nieche that thoose making mods with this will just make it properly lol

@ASpoonPlaysGames ASpoonPlaysGames marked this pull request as ready for review December 13, 2025 20:06
@Alystrasz
Copy link
Member

@ASpoonPlaysGames merge conflicts btw

@ASpoonPlaysGames
Copy link
Contributor Author

@ASpoonPlaysGames merge conflicts btw

Yeah, quite a few. Gonna basically have to rewrite this PR, don't expect it particularly soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflicts Blocked by merge conflicts, waiting on the author to resolve needs code review Changes from PR still need to be reviewed in code needs testing Changes from the PR still need to be tested

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants