Skip to content

Conversation

@ASpoonPlaysGames
Copy link
Contributor

Don't use keyvalues, just put it as if you are overriding it. I don't see a case where you want to be overriding all the particles in the game, so yeah.

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Nov 27, 2025
@ASpoonPlaysGames
Copy link
Contributor Author

Should close #273 though only for this specific file. The reality is that #base (which we (ab)use for keyvalues) doesn't seem to play nice with duplicate keys. Not sure if duplicate keys are common or anything though so whatever. I'd consider it closed personally

@Alystrasz
Copy link
Member

@ASpoonPlaysGames could you provide a way to test this?

@ASpoonPlaysGames
Copy link
Contributor Author

@ASpoonPlaysGames could you provide a way to test this?

Basically have a mod that adds new particle effects to the game, before you would have to edit an existing one. Add your particle and make a particles_manifest to make the game load it

@EM4Volts
Copy link
Contributor

Tried testing this yesterday, I believe it worked but I think confirmation from someone like s2 would be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs code review Changes from PR still need to be reviewed in code needs testing Changes from the PR still need to be tested

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants