Improve support for bots. #884
Conversation
github-actions
bot
added
needs testing
catornot
left a comment
catornot
left a comment
There was a problem hiding this comment.
I disagree with the no report part. Bots do take up player slots therefore they must be reported in some way otherwise servers could get report as not full when they are in fact full.
primedev/dedicated/dedicated.cpp
Outdated
| { | ||
| SetConsoleTitleA(fmt::format( | ||
| "{} - {} {}/{} players ({})", | ||
| "{} - {} {} ({} bots) / {} humans ({})", |
There was a problem hiding this comment.
On next docker artifact produced, it should let you pull a new image (if this gets merged)
There was a problem hiding this comment.
Does this affect docker stuff?
Yes, the regexp will need to be updated.
catornot
left a comment
catornot
left a comment
There was a problem hiding this comment.
would be probably better to fix #548 instead but this is fine as well
blocking until https://github.com/R2Northstar/NorthstarLauncher/pull/884/changes#r2651637462 is resolved
I could add support for reporting the bot count. |
but that still should be a different pr since it would need prs to multiple repos |
5 participants
Fixes crash if a bot joins a server with no other players.
Enables
sv_stressbotsplayer 2 is with stress bots player 3 is without stress bots.