Prevent invalid packet flooding #885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs testing
|
|
The formatter is gonna kill you. |
Contributor
|
is fine, works, top10 prs of all time, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a workaround to the fact that flooding
NET_ReceiveDatagramwith invalid packets, (namely invalid LZSS compression (-3) packets seeengine.dll+0x21B735) causes the server to stop receiving that frame. This adds a configurable number of times to iterate listening per call fromNET_GetPacket.Basically just pasted from R1Delta security_fixes.cpp
Code review:
🙂
Testing:
idk probably works 👍