Skip to content

Conversation

@Masterliberty
Copy link
Contributor

Arc Cannon with model, animations, tf1 weapon stats, and bug fixed _arc_cannon file.
Screenshot (2877)

Masterliberty and others added 6 commits March 8, 2023 11:28
triple threat w anims
Arc Cannon with anims, proper fixes to not crash tf2, and tf1 stats.
Removed the arc cannon commit until Triple Threat is merged.
Arc cannon with working model, animations, tf1 weapon settings .txt, and bug fixed _arc_cannon file
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GalacticMoblin
Copy link
Contributor

I would just like to mention I have a custom made Arc Cannon weapon icon I made for Archon.

@ASpoonPlaysGames
Copy link
Contributor

I would just like to mention I have a custom made Arc Cannon weapon icon I made for Archon.

probably wont get used (yet) because uimg limit

Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some quick one-player testing. Still need to test with other players:

  • Arc Cannon is added to the game as intended
  • Sound effects appear to still be missing. Separate PR?
  • This will break compat both ways between combinations of server/client old/new. There's not a really a fix for this. We will have to version gate it when we release it either way.

To test are still

  • Check the damage effect when getting hit by Arc Cannon
  • Have player without Arc Cannon join server with Arc Cannon (I expect them to be unable to connect as mentioned above)

@F1F7Y F1F7Y added the needs testing Changes from the PR still need to be tested label Apr 20, 2023
@F1F7Y
Copy link
Member

F1F7Y commented Apr 24, 2023

Sound effects appear to still be missing. Separate PR?

We can't add new sound effects so just like the triple threat itll have to stay silent

Copy link
Member

@F1F7Y F1F7Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From skimming over the code it looks good. Due to this being based on r1 the code quality wont be up to r2 standards, but just like the triple threat this is ok as the game wont be updated with a newer squirrel compiler.

Copy link
Member

@F1F7Y F1F7Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested together with #660 on Launcher #504

Works

Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in testing. Of note is that this will break compatibility in the following way:

works: ✅
breaks: ❌

Server old Server Arc Cannon
Client old
Cleint Arc Cannon

@GeckoEidechse
Copy link
Member

Alright Imma commit the original TF1 files first, then resolve merge conflicts myself and update the PR, then merge

@GeckoEidechse GeckoEidechse changed the title Arc cannon Add Arc cannon Jul 16, 2023
@GeckoEidechse GeckoEidechse merged commit 4c5cd0b into R2Northstar:main Jul 16, 2023
@ASpoonPlaysGames ASpoonPlaysGames removed the needs testing Changes from the PR still need to be tested label Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants