-
Notifications
You must be signed in to change notification settings - Fork 121
Add Arc cannon #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Arc cannon #600
Conversation
triple threat w anims
Arc Cannon with anims, proper fixes to not crash tf2, and tf1 stats.
Removed the arc cannon commit until Triple Threat is merged.
Arc cannon with working model, animations, tf1 weapon settings .txt, and bug fixed _arc_cannon file
GeckoEidechse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current version is missing weapon precaching
See https://github.com/R2Northstar/NorthstarMods/pull/276/files#diff-a449854f2677ae627216b17300ddcde22f3e3788d101a84299689c207cd1cefcR7 for reference on how to add it ^^
|
I would just like to mention I have a custom made Arc Cannon weapon icon I made for Archon. |
probably wont get used (yet) because uimg limit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some quick one-player testing. Still need to test with other players:
- Arc Cannon is added to the game as intended
- Sound effects appear to still be missing. Separate PR?
- This will break compat both ways between combinations of server/client old/new. There's not a really a fix for this. We will have to version gate it when we release it either way.
To test are still
- Check the damage effect when getting hit by Arc Cannon
- Have player without Arc Cannon join server with Arc Cannon (I expect them to be unable to connect as mentioned above)
We can't add new sound effects so just like the triple threat itll have to stay silent |
F1F7Y
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From skimming over the code it looks good. Due to this being based on r1 the code quality wont be up to r2 standards, but just like the triple threat this is ok as the game wont be updated with a newer squirrel compiler.
F1F7Y
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GeckoEidechse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works in testing. Of note is that this will break compatibility in the following way:
works: ✅
breaks: ❌
| Server old | Server Arc Cannon | |
|---|---|---|
| Client old | ✅ | ❌ |
| Cleint Arc Cannon | ✅ | ✅ |
Northstar.Custom/mod/scripts/vscripts/weapons/mp_titanweapon_arc_cannon.nut
Show resolved
Hide resolved
|
Alright Imma commit the original TF1 files first, then resolve merge conflicts myself and update the PR, then merge |
Arc Cannon with model, animations, tf1 weapon stats, and bug fixed _arc_cannon file.
