Skip to content

Conversation

@ASpoonPlaysGames
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames commented Sep 3, 2023

Marking as a draft because this relies on a new Atlas endpoint. (R2Northstar/Atlas#38)

Comment on lines +816 to +819
#if HAS_NORTHSTAR_CUSTOM
// relies on script HTTP which is in Northstar.Custom
thread GetAtlasAnnouncement_Threaded()
#endif // HAS_NORTHSTAR_CUSTOM
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done to avoid having to override ui/_menus.nut in Northstar.Custom as well.
I could have done the HTTP stuff in Launcher, but that then splits this feature into 3 PRs :/

Unfortunately this does mean that clients who have Northstar.Custom disabled will not see the announcements. This makes up a tiny proportion of the playerbase, so personally I'm not too concerned.

@github-actions github-actions bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Dec 20, 2023
@github-actions github-actions bot removed the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Aug 29, 2024
@Alystrasz
Copy link
Member

  • How do you consider displaying this information in the lobby?
  • Do you plan on opening the Atlas PR yourself?

@ASpoonPlaysGames
Copy link
Contributor Author

  • How do you consider displaying this information in the lobby?

It's already done and has been for a while, all you need to do is set some convars to display a message. Currently we display a message about progression.

  • Do you plan on opening the Atlas PR yourself?

No, I haven't touched Go before really. It would basically be the same as mainmenupromos though, perhaps with a localisation file sent in some way as well? Idk.

The linked issue details requirements.

@github-actions github-actions bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflicts Blocked by merge conflicts, waiting on the author to resolve

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants