Store GamePlayingOrSuddenDeath before calling PlayerOrNPCKilled

[ASpoonPlaysGames]

Maybe supercedes #757

Explanation for the change copied from #757:

Did some further investigation into this, it seems that as per the comment here:

NorthstarMods/Northstar.CustomServers/mod/scripts/vscripts/mp/_base_gametype.gnut

Line 711 in e05e45e

bool gamePlayingOrSuddenDeath = GamePlayingOrSuddenDeath() // Storing this off here, the game state can change in the callbacks below which may cause kills to not count

The gamestate is being changed in one of the callbacks there. The kill counts because it is checking against the old gamestate, but later on during PostDeathThread_MP when we handle the death stat, the gamestate has been changed already so we get a mismatch

The check we use should really be if ( GamePlayingOrSuddenDeath() && !file.playerDeathsHidden ) we just have an order of operations issue underlying this.

EDIT:
in _gamestate_mp.nut a player killed callback is registered, which handles checking for final kills, and setting the winning team. The order of operations is as follows:

• player is killed
• gamestate is stored for tracking kills
• winner is determined due to final kill logic (gamestate changes)
• stored gamestate is checked for tracking kills
• non-stored gamestate is checked for tracking deaths and death is not registered

[Alystrasz]

Logic looks good.
Merging to test in production.