Fix for Ion's Aegis Laser Core Duration #964
Conversation
Zanieon
added
the
commits vanilla file
github-actions
bot
added
needs testing
github-actions
bot
added
the
merge conflicts
Alystrasz
left a comment
Alystrasz
left a comment
There was a problem hiding this comment.
Have you tested this change?
| float coreFrac = min( 1.0, remainingTime / duration ) | ||
| //Defensive fix for this sometimes resulting in a negative value. | ||
| if ( coreFrac > 0.0 ) | ||
| if ( coreFrac > 0.01 ) |
There was a problem hiding this comment.
Ends the state of Core active early and is actually what prevents Ion from getting stuck in there after the laser finishes.
github-actions
bot
removed
the
merge conflicts
|
This sounds like a bug in how vanilla implements it, I thought we don't fix those unless it's some heavy issue like the splitter rifle dps |
|
Ion not being able to gain core back if the laser ends prematurely in comparison to the core meter is quite important in FD, mind that this is an Aegis Laser Core fix, it does not affect Ion in normal core even with Grand Cannon kit. |
|
how to test this? |
Max aegis Ion -> laser core -> kill a bunch of stuff with the core -> core should end at the right time (should match UI in the bottom left) |
6 participants
From discord:
Laser Core was supposed to have extended sustain like Sword Core as long as kills are being made to stack up the time, however Laser Core ends early if nothing is killed in a 5 second window, despite the core meter saying it is active, it just ends prematurely, and with the core meter being stuck in the active state when it is no longer active entirely prevents Ion from building up core again