Skip to content

Conversation

@ASillyNeko
Copy link
Contributor

No description provided.

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Jan 3, 2026
@ASillyNeko
Copy link
Contributor Author

Unplayable bug.

With fix.
image

Without fix.
image

bool function MeleeThread_PilotVsEnemy( SyncedMelee action, entity attacker, entity target )
{
// function off for reload scripts
return MeleeThread_PilotVsEnemyInternal( action, attacker, target )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this need to be cloned?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

classic_executions will replace the action.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd kinda prefer if it was only cloned in that edge case if possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs code review Changes from PR still need to be reviewed in code needs testing Changes from the PR still need to be tested

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants