mp_sanctuary verification request

[CodyIBrealey]

added my mod. hope all this works

mp_sanctuary v0.0.1

Did I read the whole README file and understood all of its content?

YES

Did I update verified-mods.json with my new mod's information?

YES

Has a previous version of my mod been previously verified?

NO

Mod description

Literally the third best titanfall 2 map ever created

Thunderstore link

(https://thunderstore.io/c/northstar/p/skrubslayer69/mp_sanctuary/)

[catornot]

The mod is to packaged incorrectly,
mods/skrubslayer.mp_sanctuary/mod needs to become mod afaik

[ASillyNeko]

no mod.json file.

[CodyIBrealey]

updated to hopefully fix this. Moved the mod.json file to the correct location, comparing to mp_brick it seems like that particular folder is supposed to be called "mod" rather than "mods", though if it still doesn't work right then that can be corrected.

[catornot]

Yeah still doesn't work
you need to collapse mods/skrubslayer.mp_sanctuary into the root dir :)
like mp_bricks

[CodyIBrealey]

Fixed the file structure as instructed. Hopefully third times the charm.

[catornot]

yeah ci failed

[Alystrasz]

• CI verification passes
• Commit hash is OK
• Checksum is OK
• No malicious scripts inside mod itself, and no use of "dangerous" ¹ functions

LGTM.

Footnotes

1. e.g.: Safe I/O stuff and SquirrelHTTP. "dangerous" is a bit too much maybe. Under the assumption that the native implementations are correct and secure, there's nothing dangerous here. However it's always recommended to use more of a Swiss cheese approach and also operate a bit under the assumption that a layer can fail. ↩